이미지 편집 뷰 Layout #40
Merged
이미지 편집 뷰 Layout #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
iceHood
approved these changes
Nov 10, 2024
yuncheol-AHN
approved these changes
Nov 10, 2024
Comment on lines
+62
to
65
| func setCenter(view: UIView, offset: CGPoint = CGPoint(x: 0, y: 0)) { | ||
| self.translatesAutoresizingMaskIntoConstraints = false | ||
| self.centerXAnchor.constraint(equalTo: view.centerXAnchor, constant: offset.x).isActive = true | ||
| self.centerYAnchor.constraint(equalTo: view.centerYAnchor, constant: offset.y).isActive = true |
There was a problem hiding this comment.
P3
center에서 이동이 필요한 경우라면 기존 함수에 새로운 함수를 추가하는 것도 좋아보입니다!
예를들어, func setCenter(view:UIView), func setCenterTo(view: UIView, to offset: CGPoint)
There was a problem hiding this comment.
음! 이 함수가 원래는 offset에 default 값이 없어서 제가 따로 저렇게 넣어준 것이었는데,, 저는 개인적으로 그냥 offset이라는 매개변수가 없어도 되지 않나라는 생각이긴합니다 ..! 일단 효준님께서 저렇게 만드신데에는 이유가 있으실 것 같아 default를 넣어주는 방식으로 해결했는데, 함수를 분리해서 하나 더 만드는게 좋을까요..??
There was a problem hiding this comment.
두분을 거친 코드였군요! 일단 사용해도 괜찮을 거 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
📒 리뷰 노트
최대한 깔끔하게 써보려 노력했지만.. constraints 잡는 부분과 property 부분이 많이 더럽습니다..
가운데 dimmed 되어있는 부분은 어떻게 처리할까 고민해보다가 ImageView 위에 Dimmed View 2개와 실제 들어갈 부분을 나타내는 Clear View 1개를 addSubView 해주었습니다. AutoLayout으로 잡아서 4:3 비율로 들어가게끔 만들어줬는데, 불필요하게 코드가 길어진건가.. 싶습니다.. 더 좋은 방법이 있다면 알려주시면 감사하겠습니다 .ᐟ.ᐟ 🙇🏻♀️🙇🏻♀️
📸 스크린샷