-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
이미지 Crop 구현 및 TextField 위치 조정, CustomAlbum ViewModel 구조 리팩토링 #66
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2e47868
Merge branch 'develop' into feature/crop-image
k2645 72a0ffc
feat: 카메라 권한 로직 구현
k2645 9b12f6e
feat: 커스텀 앨범이 사용자 앨범의 update를 옵저빙하는 기능 구현
k2645 82c9e8a
chore: 필요 없는 image set 삭제
k2645 8bb7985
feat: 이미지 뷰에 PanGesture와 PinchGesture 추가
k2645 7439b33
feat: scrollView를 이용한 이미지 zoom in-out
k2645 f6c4f47
feat: scroll view zoom, scroll 제한 설정
k2645 6edc9e1
feat: 캡션 textField 키보드에 따른 위치 조절
k2645 a238def
feat: 커스텀 앨범의 navigation bar 색상 설정
k2645 c6c1c62
feat: 이미지 크롭..완..
k2645 bc4cc50
fix: setPhoto 매개변수 수정
k2645 ce5b004
refactor: custom view 내부 프로퍼티 네이밍 수정
k2645 1d8149c
Merge branch 'develop' into feature/crop-image
k2645 4da102c
chore: 주석 추가
k2645 d78817a
refactor: 바인딩 구조 리팩토링
k2645 ee6f6c2
fix: navigation bar 재설정
k2645 2a6021a
refactor: 리뷰 피드백 반영
k2645 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
23 changes: 0 additions & 23 deletions
23
...e/MHPresentation/MHPresentation/Resource/Images.xcassets/CropImage.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-368 Bytes
...resentation/MHPresentation/Resource/Images.xcassets/CropImage.imageset/Crop.png
Binary file not shown.
Binary file removed
BIN
-556 Bytes
...entation/MHPresentation/Resource/Images.xcassets/CropImage.imageset/[email protected]
Binary file not shown.
Binary file removed
BIN
-827 Bytes
...entation/MHPresentation/Resource/Images.xcassets/CropImage.imageset/[email protected]
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3
제가 이번에 올린 PR에 네비게이션 아이템 만드는 편의 생성자 Extension 추가해둬서
영현님이 보시기에 가독성 증가 필요 시 적용해보셔도 좋을 것 같습니다 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
효준님 PR 머지되고 나서 다음 제 PR에서 수정하겠습니당 .ᐟ.ᐟ 효준님께서 만들어주신 편의 생성자 정말 좋은 것 같아요 .ᐟ.ᐟ