-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE - #109 ] Quiz-Session 소켓 연결 및 리팩토링 #110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- floatDown : 아래로 내려오는 애니메이션 - swing : 좌우로 왔다갔다 하는 애니메이션
dooohun
approved these changes
Nov 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~
quiz: QuizData; | ||
tick: { currentTime: number; elapsedTime: number; remainingTime: number }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요 친구도 따로 빼도 좋을 거 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
[#109] QUIZ 관련 소켓 연결하기
📝작업 내용
Quiz Background 컴포넌트 index.tsx -> QuizBox.tsx
유저가 이모지를 클릭하거 이모지 이벤트를 받을 경우 index.tsx에 존재하는
reaction State
로 인해 퀴즈 세션 페이지 전체가 렌더링되는 이슈가 있었습니다.reactionState
를 QuizBox 컴포넌트로 이동하고 Quiz Background 컴포넌트도 QuizBox 컴포넌트로 이동하여 전체 페이지가 렌더링되지 않도록 수정하였습니다.스크린샷
💬리뷰 요구사항
참고 자료