♻️ refactor: 여러 종목에 대한 구독 해제 요청을 한번에 할 수 있도록 배열로 변경#250

boostcampwm-2024 · Dec 2, 2024 · 9c7248a · 9c7248a
1 parent 576d8c7
commit 9c7248a
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 54 deletions.
diff --git a/BE/src/asset/asset.service.ts b/BE/src/asset/asset.service.ts
@@ -157,8 +157,8 @@ export class AssetService {
     const userStocks: UserStock[] =
       await this.userStockRepository.findAllDistinctCode(userId);
 
-    userStocks.map((userStock) =>
-      this.stockPriceSocketService.unsubscribeByCode(userStock.stock_code),
+    this.stockPriceSocketService.unsubscribeByCode(
+      userStocks.map((userStock) => userStock.stock_code),
     );
   }
 

diff --git a/BE/src/stock/order/stock-order.service.ts b/BE/src/stock/order/stock-order.service.ts
@@ -111,7 +111,7 @@ export class StockOrderService {
         status: StatusType.PENDING,
       }))
     )
-      this.stockPriceSocketService.unsubscribeByCode(order.stock_code);
+      this.stockPriceSocketService.unsubscribeByCode([order.stock_code]);
   }
 
   async getPendingListByUserId(userId: number) {
@@ -135,10 +135,8 @@ export class StockOrderService {
     const orders: Order[] =
       await this.stockOrderRepository.findAllCodeByStatus();
 
-    await Promise.all(
-      orders.map((order) =>
-        this.stockPriceSocketService.unsubscribeByCode(order.stock_code),
-      ),
+    this.stockPriceSocketService.unsubscribeByCode(
+      orders.map((order) => order.stock_code),
     );
 
     await this.stockOrderRepository.delete({ status: StatusType.PENDING });

diff --git a/BE/src/stock/trade/history/stock-trade-history.controller.ts b/BE/src/stock/trade/history/stock-trade-history.controller.ts
@@ -1,10 +1,14 @@
-import { Observable } from 'rxjs';
-import { Controller, Get, Param, Sse } from '@nestjs/common';
-import { ApiOperation, ApiParam, ApiResponse, ApiTags } from '@nestjs/swagger';
+import { Controller, Get, Param, Query } from '@nestjs/common';
+import {
+  ApiOperation,
+  ApiParam,
+  ApiQuery,
+  ApiResponse,
+  ApiTags,
+} from '@nestjs/swagger';
 import { StockTradeHistoryService } from './stock-trade-history.service';
 import { TodayStockTradeHistoryDataDto } from './dto/today-stock-trade-history-data.dto';
 import { DailyStockTradeHistoryDataDto } from './dto/daily-stock-trade-history-data.dto';
-import { SseEvent } from './interface/sse-event';
 import { StockPriceSocketService } from '../../../stockSocket/stock-price-socket.service';
 
 @ApiTags('주식현재가 체결 조회 API')
@@ -51,50 +55,27 @@ export class StockTradeHistoryController {
     return this.stockTradeHistoryService.getDailyStockTradeHistory(stockCode);
   }
 
-  @Sse(':stockCode/today-sse')
-  @ApiOperation({ summary: '단일 주식 종목에 대한 실시간 체결 데이터 스트림' })
-  @ApiParam({
-    name: 'stockCode',
-    required: true,
-    description:
-      '종목 코드\n\n' +
-      '(ex) 005930 삼성전자 / 005380 현대차 / 001500 현대차증권',
-  })
-  @ApiResponse({
-    status: 200,
-    description:
-      '단일 주식 종목에 대한 주식현재가 체결값 실시간 데이터 조회 성공',
-    type: TodayStockTradeHistoryDataDto,
-  })
-  streamTradeHistory(@Param('stockCode') stockCode: string) {
-    this.stockPriceSocketService.subscribeByCode(stockCode);
-
-    return new Observable<SseEvent>((subscriber) => {
-      const subscription = this.stockPriceSocketService
-        .getTradeDataStream(stockCode)
-        .subscribe(subscriber);
-
-      return () => {
-        this.stockPriceSocketService.unsubscribeByCode(stockCode);
-        subscription.unsubscribe();
-      };
-    });
-  }
-
-  @Get(':stockCode/unsubscribe')
+  @Get('/unsubscribe')
   @ApiOperation({ summary: '페이지를 벗어날 때 구독을 취소하기 위한 API' })
-  @ApiParam({
+  @ApiQuery({
     name: 'stockCode',
     required: true,
     description:
       '종목 코드\n\n' +
       '(ex) 005930 삼성전자 / 005380 현대차 / 001500 현대차증권',
+    schema: {
+      type: 'array',
+      items: {
+        type: 'string',
+      },
+    },
   })
   @ApiResponse({
     status: 200,
     description: '구독 취소 성공',
   })
-  unsubscribeCode(@Param('stockCode') stockCode: string) {
-    this.stockPriceSocketService.unsubscribeByCode(stockCode);
+  unsubscribeCode(@Query('stockCode') stockCode: string | string[]) {
+    const stockCodeArray = Array.isArray(stockCode) ? stockCode : [stockCode];
+    this.stockPriceSocketService.unsubscribeByCode(stockCodeArray);
   }
 }
diff --git a/BE/src/stockSocket/stock-price-socket.service.ts b/BE/src/stockSocket/stock-price-socket.service.ts
@@ -73,14 +73,16 @@ export class StockPriceSocketService extends BaseStockSocketDomainService {
     this.connection[trKey] = 1;
   }
 
-  unsubscribeByCode(trKey: string) {
-    if (!this.connection[trKey]) return;
-    if (this.connection[trKey] > 1) {
-      this.connection[trKey] -= 1;
-      return;
-    }
-    delete this.connection[trKey];
-    this.baseSocketDomainService.unregisterCode(this.TR_ID, trKey);
+  unsubscribeByCode(trKeys: string[]) {
+    trKeys.forEach((trKey) => {
+      if (!this.connection[trKey]) return;
+      if (this.connection[trKey] > 1) {
+        this.connection[trKey] -= 1;
+        return;
+      }
+      delete this.connection[trKey];
+      this.baseSocketDomainService.unregisterCode(this.TR_ID, trKey);
+    });
   }
 
   private async checkExecutableOrder(stockCode: string, value) {
@@ -103,6 +105,6 @@ export class StockPriceSocketService extends BaseStockSocketDomainService {
         status: StatusType.PENDING,
       }))
     )
-      this.unsubscribeByCode(stockCode);
+      this.unsubscribeByCode([stockCode]);
   }
 }