Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4] 2.03 로그인 기능 구현 #33

Merged
merged 46 commits into from
Nov 7, 2024
Merged

Conversation

jinddings
Copy link
Collaborator

✅ 주요 작업

💭 고민과 해결과정

  • try-catch를 사용해 오류 처리를 진행했는데 logger로 오류가 잡히지 않아 헤맸는데 메소드 진입 전에 pipe에서 걸러져서 예외 응답을 전송중이었다..!

jinddings and others added 30 commits November 6, 2024 13:14
오늘의 상/하위 종목 조회를 위해 필요한 access_token 발급 로직 구현
오늘의 상/하위 종목 조회를 위해 필요한 DTO 구현
한국투자 Open API를 활용해 정보를 요청하고, 해당 정보를 모두 가져와 저장하는 로직 구현
@jinddings jinddings changed the base branch from main to back/main November 6, 2024 10:15
@jinddings jinddings requested review from uuuo3o and sieunie November 6, 2024 10:16
@jinddings jinddings linked an issue Nov 6, 2024 that may be closed by this pull request
Copy link
Collaborator

@sieunie sieunie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다~

TypeOrmModule.forFeature([User]),
PassportModule.register({ defaultStrategy: 'jwt' }),
JwtModule.register({
secret: 'Juga16',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 얘가 혹시 JWT secret key인가요???? 이거는 노출되면 안될 거 같은데..ㅎㅎㅎㅎ

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하겠습니다!

@jinddings jinddings merged commit 5c28839 into back/main Nov 7, 2024
1 of 2 checks passed
@uuuo3o uuuo3o added BE 백엔드 API API 구현 labels Nov 8, 2024
@sieunie sieunie deleted the feature/api/login-#4 branch November 21, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API 구현 BE 백엔드
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BE] 2.03 로그인 기능 구현
3 participants