Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#6] 3.02 주식차트 정보 기능 구현 수정 #37

Merged
merged 3 commits into from
Nov 7, 2024
Merged

[#6] 3.02 주식차트 정보 기능 구현 수정 #37

merged 3 commits into from
Nov 7, 2024

Conversation

sieunie
Copy link
Collaborator

@sieunie sieunie commented Nov 7, 2024 •
edited
Loading

✅ 주요 작업

  • socket 관련한 로직을 수정해 정상 작동하게 함
  • 주가 지수 API response 형식을 수정함

💭 고민과 해결과정

  • Cron 로직을 어디 두어야 할까 고민이 있었는데, 의존성 등 여러 요소를 고려해서 stockindex controller에 배치하는 것으로 결정했다.

@sieunie sieunie requested review from uuuo3o and jinddings November 7, 2024 06:27
@sieunie sieunie self-assigned this Nov 7, 2024
@sieunie sieunie linked an issue Nov 7, 2024 that may be closed by this pull request
[BE] 3.02 주식 차트 정보 기능 구현 #6
Closed
uuuo3o
uuuo3o reviewed Nov 7, 2024
View reviewed changes
BE/src/app.module.ts
@@ -30,8 +31,9 @@ import { KoreaInvestmentModule } from './koreaInvestment/korea.investment.module
AuthModule,
StockIndexModule,
StockTopfiveModule,
SocketModule,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 모듈로 분리해서 socket 통신도 accessToken 성공하신건가요? 좋네요!

@sieunie sieunie changed the title [#6] 3.02 🔧 fix: socket 관련 로직 수정 [#6] 3.02 주식차트 정보 기능 구현 수정 Nov 7, 2024
@sieunie sieunie merged commit 8a36bb1 into back/main Nov 7, 2024
2 checks passed
@uuuo3o uuuo3o added BE 백엔드 REFACTORING 코드 리팩터링 labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uuuo3o uuuo3o uuuo3o approved these changes

@jinddings jinddings Awaiting requested review from jinddings

Assignees

@sieunie sieunie

Labels
BE 백엔드 REFACTORING 코드 리팩터링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] 3.02 주식 차트 정보 기능 구현
2 participants
@sieunie @uuuo3o