Bug/#315 unsubscribe, subscribe에 queue 적용 #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
xjfcnfw3
approved these changes
Dec 3, 2024
|
|
||
| await this.mutex.runExclusive(async () => { | ||
| const connectedSockets = await this.server.to(stockId).fetchSockets(); | ||
| try { |
There was a problem hiding this comment.
현재 try-catch로 에러처리하는 부분이 따로 없고, 외부 유저와 connection하는 부분이다 보니 예기치 못한 에러가 발생할 수 있다고 생각했습니다
| @@ -7,24 +6,23 @@ import { RawData, WebSocket } from 'ws'; | |||
| export class WebsocketClient { | |||
| static url = process.env.WS_URL ?? 'ws://ops.koreainvestment.com:21000'; | |||
| private client: WebSocket; | |||
| //현재 factory 패턴을 이용해 할당하면 socket이 열리기 전에 message가 가는 문제가 있음. | |||
| // 소켓이 할당되기 전에(client에 소켓이 없을 때) message를 보내려 시도함. | |||
| private messageQueue: string[] = []; | |||
There was a problem hiding this comment.
shift하면 비용이 n이라 비효율적이라 큐를 쓰는게 좋긴하지만, JS에서는 직접 구현해야되는게 아쉽네요
There was a problem hiding this comment.
이건 너무 아쉽습니다. 큐 말고 더 좋은 방법이 있을까 해서 onModuleInit도 고려했는 데, websocket을 열 수 있는 개수를 런타임때야 알 수 있으니 어쩔 수 없었다고 생각합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #336
✅ 작업 내용
😎 체크 사항