Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#378 - 쿼리 캐싱, 무효화 설정 및 자잘한 에러 수정, 스켈레톤 추가 #380

Merged
merged 8 commits into from
Dec 5, 2024
Next Next commit
🐛 fix: 알림 거래가, 목표가 타입 변경
baegyeong committed Dec 5, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit d5c12d20e8667514239cf30e0164e9a293cbf809
2 changes: 1 addition & 1 deletion packages/frontend/src/components/ui/alarm/Alarm.tsx
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ import Flag from '@/assets/flag.svg?react';

export interface AlarmProps {
option: string;
goalPrice: number | string;
goalPrice: number;
alarmDate: string | null;
}

Original file line number Diff line number Diff line change
@@ -36,14 +36,18 @@ const NotificationContents = () => {
}

if (!data) {
return <p className="text-center">알림 정보를 불러오는 데 실패했어요.</p>;
}

if (data.length === 0) {
return <p className="text-center">현재 설정된 알림이 없어요.</p>;
}

return data.map((alarm) => (
<Alarm
key={alarm.alarmId}
option={alarm.targetPrice ? '목표가' : '거래가'}
goalPrice={alarm.targetPrice ?? alarm.targetVolume!}
goalPrice={alarm.targetPrice ?? alarm.targetVolume ?? 0}
alarmDate={alarm.alarmExpiredDate}
/>
));