-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 발화자 하이라이팅 구현 #352
Draft
simeunseo
wants to merge
12
commits into
develop
Choose a base branch
from
feat/#45/speaker-highlighting
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Feat] 발화자 하이라이팅 구현 #352
+270
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeunseo
requested review from
seoko97,
begong313,
Jieun1ee and
Fixtar
as code owners
December 2, 2024 19:26
🎨 스토리북 확인하기
|
begong313
approved these changes
Dec 3, 2024
seoko97
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
작업 내용
PR 포인트
아무래도 지속적인 계산이 들어가다보니 스트리밍에 대한 안정성이 떨어진걸로 느껴지는데, 확실한건 다같이 접속해봐야알 것 같습니다.
실제 발화자 하이라이팅이 잘 되는지도 다같이 접속해봐야 알 수 있을 것 같습니다.
그리고 현재 자신의 발화에 대한 하이라이팅은 적용이 되지 않는 상황입니다.
고민과 학습내용
활성 화자에 대한 하이라이팅 보여주기
학습정리 내용입니다. 아직 다 못적었습니다ㅠ
스크린샷
2024-12-03.4.19.40.mov