-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Space 화면 Header UI 구현 #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 데이터를 가져오는 것에 따라 추가 수정 필요
hoqn
force-pushed
the
feature/breadcrumb
branch
from
November 26, 2024 16:29
ce6cb15
to
35244ba
Compare
hoqn
requested review from
heegenie and
CatyJazzy
and removed request for
a team
November 27, 2024 03:00
CatyJazzy
reviewed
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
빠르게 구현해서 올려주신 PR이었는데 .. 늦은 리뷰 죄송합니다.
코멘트는 사소한 것들이라 가볍게 체크해주셔도 될 것 같습니다 👍
CatyJazzy
approved these changes
Nov 27, 2024
heegenie
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다른 부분은 지후님이 이미 리뷰를 잘 남겨 주셔서..
간단하게만 코멘트 남기고 Approve 하겠습니다 🐝
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ 한 줄 설명
Space 페이지의 헤더 UI를 구현했습니다.
✅ 작업 내용
🏷️ 관련 이슈
📸 스크린샷/영상
브레드크럼은 아래와 같이 동적으로 작동하도록 하였습니다.
둘 이하
셋
넷 이상
헤더는 다음과 같이 구성하였습니다.
📌 리뷰 진행 시 참고 사항
5점: 우선은 Space 페이지 헤더 UI만 구현했습니다. 백엔드 연동으로 브레드크럼 실제로 띄우고, 공유 버튼 구현하는 부분은 별도 PR로 올리겠습니다!