-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Space 삭제 API 작업 #200
Closed
Closed
Space 삭제 API 작업 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fru1tworld
requested review from
parkblo and
CatyJazzy
and removed request for
a team
December 3, 2024 06:31
fix: 노드 위 우클릭 시 이동모드 활성화되는 것 방지
* fix: mouse-event에 대해서만 button 판별하도록 수정
* feat: 인터랙션 가이드 추가 * chore: 인터랙션 가이드 내용 추가
* feat: 터치디바이스 여부 확인 로직 * feat: 모바일환경에서 더보기 버튼 클릭 시 context-menu 표시 * feat: 더보기 버튼 클릭 시 clientX, clientY값 정의하여 전달 * feat: 간선 삭제 버튼 스타일 수정 * feat: 삭제 버튼 터치 핸들러 연결
parkblo
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현진님 고생 많으셨습니다!
테스트 코드도 놓치지 않고 잘 작성하시는 모습이 멋있어요 👍
this.logger.log( | ||
`서브스페이스 노드 삭제 - ID: ${node.id}, 하위 스페이스 ID: ${node.src}`, | ||
); | ||
await this.deleteById(node.src); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
재귀적으로 삭제를 처리하는 로직 좋아요 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ 한 줄 설명
Space 삭제 API 작업
✅ 작업 내용
Space 삭제 API 작업
Node type에 따라서 NoteService.delete혹은 SpaceService.delete로 나뉩니다.
🏷️ 관련 이슈
📸 스크린샷/영상
📌 리뷰 진행 시 참고 사항