Head Node UI 구현 #85
Merged
Head Node UI 구현 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hoqn
force-pushed
the
feature/head-node-ui
branch
from
325099a to
216d5eb
Compare
hoqn
requested review from
parkblo and
fru1tworld
and removed request for
a team
fru1tworld
approved these changes
Nov 11, 2024
|
고생하셨습니다 b |
parkblo
approved these changes
Nov 11, 2024
| ); | ||
| }, | ||
| ], | ||
| } satisfies Meta<typeof SpaceNode>; |
There was a problem hiding this comment.
satisfies를 통해서 타입 체킹을 할 수도 있군요 👀
Comment on lines
+10
to
+25
| const [offsetX, setOffsetX] = useState<number | undefined>(undefined); | ||
| const [offsetY, setOffsetY] = useState<number | undefined>(undefined); | ||
|
|
||
| useEffect(() => { | ||
| if (!ref.current || props.offset !== undefined) { | ||
| return; | ||
| } | ||
|
|
||
| if (props.offsetX === undefined) { | ||
| setOffsetX(ref.current.width() / 2); | ||
| } | ||
|
|
||
| if (props.offsetY === undefined) { | ||
| setOffsetY(ref.current.height() / 2); | ||
| } | ||
| }, [props]); |
There was a problem hiding this comment.
offsetX, offsetY를 offset 하나로 관리하면 조금 더 간결해질 것 같아요. (1점)
| const SpaceNode = forwardRef<Konva.Group, SpaceNodeProps>( | ||
| ({ label, x, y }, ref) => { | ||
| // TODO: 색상에 대해 정하기, 크기에 대해 정하기 | ||
| const fillColor = "royalblue"; |
| const { entrySpaceId } = useParams<SpacePageParams>(); | ||
|
|
||
| if (!entrySpaceId) { | ||
| throw new Error(""); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(rebase해서 올렸습니다)
✏️ 한 줄 설명
Space 페이지를 생성하고, 중앙 노드가 렌더링되도록 했어요.
✅ 작업 내용
🏷️ 관련 이슈
close #28
📸 스크린샷/영상
📌 리뷰 진행 시 참고 사항
아직 확장성 있게 컴포넌트를 설계하기엔 데이터 구조랑이 명확해지기 전까지는 어려울 것 같아, 개략적인 구조만 잡았습니다.