Skip to content

Commit

Permalink
๐Ÿšจ !HOTFIX!: meta ํƒœ๊ทธ๋ฅผ ์ธ์‹ํ•˜์ง€ ๋ชปํ•˜๋Š” ๋ฌธ์ œ ํ•ด๊ฒฐ
Browse files Browse the repository at this point in the history
  • Loading branch information
lee0jae330 committed Dec 6, 2024
1 parent 1bf3a73 commit fc7e5f1
Show file tree
Hide file tree
Showing 4 changed files with 34 additions and 33 deletions.
43 changes: 34 additions & 9 deletions apps/client/src/app/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { ToasterWithMax } from '@/shared/ui';
import { ErrorPage } from '@/pages/ErrorPage/ErrorPage';
import { lazy, Suspense } from 'react';
import { Loading } from '@/shared/ui';
import { Helmet } from 'react-helmet-async';

// lazy ๋กœ๋”ฉ
const HomePage = lazy(() =>
Expand All @@ -23,27 +24,51 @@ const router = createBrowserRouter([
{
path: '/',
element: (
<Suspense fallback={<Loading />}>
<HomePage />
</Suspense>
<>
<Helmet>
<title>BooLock - ํ™ˆ</title>
<meta
name="description"
content="์ฝ”๋”ฉ ์ž…๋ฌธ์ž๋“ค์ด HTML๊ณผ CSS๋ฅผ ๋ธ”๋ก์œผ๋กœ ๋ฐฐ์šฐ๋Š” BooLock์˜ ๋ฉ”์ธ ํŽ˜์ด์ง€์ž…๋‹ˆ๋‹ค."
/>
</Helmet>
<Suspense fallback={<Loading />}>
<HomePage />
</Suspense>
</>
),
errorElement: <ErrorPage />,
},
{
path: '/workspace/:workspaceId',
element: (
<Suspense fallback={<Loading />}>
<WorkspacePage />
</Suspense>
<>
<Helmet>
<title>BooLock - ์ž‘์—… ๊ณต๊ฐ„</title>
<meta name="description" content={`์›Œํฌ์ŠคํŽ˜์ด์Šค์—์„œ HTML๊ณผ CSS๋ฅผ ์—ฐ์Šตํ•ด๋ณด์„ธ์š”.`} />
</Helmet>
<Suspense fallback={<Loading />}>
<WorkspacePage />
</Suspense>
</>
),
errorElement: <ErrorPage />,
},
{
path: '*',
element: (
<Suspense fallback={<Loading />}>
<NotFound />
</Suspense>
<>
<Helmet>
<title>BooLock - ํŽ˜์ด์ง€๋ฅผ ์ฐพ์„ ์ˆ˜ ์—†์Œ</title>
<meta
name="description"
content="์š”์ฒญํ•œ ํŽ˜์ด์ง€๋ฅผ ์ฐพ์„ ์ˆ˜ ์—†์Šต๋‹ˆ๋‹ค. ๋‹ค๋ฅธ ํŽ˜์ด์ง€๋ฅผ ํ™•์ธํ•ด ์ฃผ์„ธ์š”."
/>
</Helmet>
<Suspense fallback={<Loading />}>
<NotFound />
</Suspense>
</>
),
},
]);
Expand Down
8 changes: 0 additions & 8 deletions apps/client/src/pages/HomePage/HomePage.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { Banner, HomeHeader, WorkspaceContainer, WorkspaceModal } from '@/widgets';
import { useClassBlockStore, useLoadingStore, useWorkspaceStore } from '@/shared/store';

import { Helmet } from 'react-helmet-async';
import { Loading } from '@/shared/ui';
import { useEffect } from 'react';

Expand All @@ -23,13 +22,6 @@ export const HomePage = () => {

return (
<>
<Helmet>
<title>BooLock - ํ™ˆ</title>
<meta
name="description"
content="์ฝ”๋”ฉ ์ž…๋ฌธ์ž๋“ค์ด HTML๊ณผ CSS๋ฅผ ๋ธ”๋ก์œผ๋กœ ๋ฐฐ์šฐ๋Š” BooLock์˜ ๋ฉ”์ธ ํŽ˜์ด์ง€์ž…๋‹ˆ๋‹ค."
/>
</Helmet>
{isPending && <Loading />}
<div className="flex h-full w-full flex-col items-center">
<HomeHeader />
Expand Down
8 changes: 0 additions & 8 deletions apps/client/src/pages/NotFound/NotFound.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { Helmet } from 'react-helmet-async';
import { ErrorContent } from '@/shared/ui/error/ErrorContent';

// TODO: ๋ฉ”์„ธ์ง€ ์ƒ์ˆ˜ํ™” shared/utils/constants.ts ์•ˆ์— ๊ด€๋ฆฌ
Expand All @@ -10,13 +9,6 @@ import { ErrorContent } from '@/shared/ui/error/ErrorContent';
export const NotFound = () => {
return (
<>
<Helmet>
<title>BooLock - ํŽ˜์ด์ง€๋ฅผ ์ฐพ์„ ์ˆ˜ ์—†์Œ</title>
<meta
name="description"
content="์š”์ฒญํ•œ ํŽ˜์ด์ง€๋ฅผ ์ฐพ์„ ์ˆ˜ ์—†์Šต๋‹ˆ๋‹ค. ๋‹ค๋ฅธ ํŽ˜์ด์ง€๋ฅผ ํ™•์ธํ•ด ์ฃผ์„ธ์š”."
/>
</Helmet>
<ErrorContent description={`์œ ํšจํ•œ ํŽ˜์ด์ง€๊ฐ€ ์•„๋‹™๋‹ˆ๋‹ค! \n๋‹ค๋ฅธ ํŽ˜์ด์ง€์—์„œ ๋งŒ๋‚˜์š”!`} />
</>
);
Expand Down
8 changes: 0 additions & 8 deletions apps/client/src/pages/Workspacepage/WorkspacePage.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { ImageTagModal, CoachMark, WorkspaceContent, WorkspacePageHeader } from '@/widgets';
import { useGetWorkspace, usePreventLeaveWorkspacePage } from '@/shared/hooks';
import { Helmet } from 'react-helmet-async';
import { Loading } from '@/shared/ui';
import { NotFound } from '@/pages/NotFound/NotFound';
import { useParams } from 'react-router-dom';
Expand Down Expand Up @@ -43,13 +42,6 @@ export const WorkspacePage = () => {

return (
<>
<Helmet>
<title>BooLock - ์ž‘์—… ๊ณต๊ฐ„</title>
<meta
name="description"
content={`์ž‘์—… ๊ณต๊ฐ„ ID: ${workspaceId}์—์„œ HTML๊ณผ CSS๋ฅผ ์—ฐ์Šตํ•ด๋ณด์„ธ์š”.`}
/>
</Helmet>
<div className="flex h-screen flex-col">
{isPending && <Loading />}
{isCoachMarkOpen && <CoachMark />}
Expand Down

0 comments on commit fc7e5f1

Please sign in to comment.