refactor: [BE] 코드 타임아웃 리팩터링

timeout : promise에서 옵션 방식으로 수정
boostcampwm2023 · Dec 17, 2023 · 87b8771 · 87b8771
1 parent 1d61a2d
commit 87b8771
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/backEnd/running/src/codes/codes.service.ts b/backEnd/running/src/codes/codes.service.ts
@@ -80,11 +80,9 @@ export class CodesService {
       try {
         const childProcess = spawn(commandParts[0], commandParts.slice(1), {
           env: { STOP: "DON'T TRY TO ATTACK!!! PLZ..." },
+          timeout: this.timeOut,
+          killSignal: this.killSignal,
         });
-        const timer = setTimeout(() => {
-          this.logger.log('timeout!');
-          childProcess.kill(this.killSignal);
-        }, this.timeOut);
 
         childProcess.stdout.on('data', (data) => {
           stdout.push(data);
@@ -96,10 +94,10 @@ export class CodesService {
 
         childProcess.on('close', (code, signal) => {
           this.logger.log(`child process exited with code ${code}, ${signal}`);
-          clearTimeout(timer);
           const out = Buffer.concat(stdout).toString();
           let err = Buffer.concat(stderr).toString();
           if (this.isTimeout(code, signal)) {
+            this.logger.log('timeout!');
             err = Messages.TIMEOUT;
           }
           resolve({ stdout: out, stderr: err });