[FE] fix: Home으로 돌아가는 경우 setting을 Off로 변경 #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 설명
Home으로 돌아가는 경우 setting을 Off로 변경
✅ 완료한 기능 명세
고민과 해결과정
기존에 room에 들어갔다가 다시 home으로 돌아오는경우 state가 유지되기때문에 isSettingOn이 true라서 방설정 창을 거치지 않고 넘어가는 문제가 있었다.
home이 마운트될 때 settingDone값을 명시적으로 off로 바꿔서 해결했다.