Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] roomConfig 상태를 통해 Connection을 핸들링 하도록 처리 #212

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

d0422
Copy link
Collaborator

@d0422 d0422 commented Dec 7, 2023

PR 설명

roomConfig 상태를 통해 Connection을 핸들링 하도록 처리

✅ 완료한 기능 명세

  • 방이 꽉찬 경우(4명) 들어올 수 없도록 처리
  • 설정 창에서 시그널링을 처리한 후 접속하도록 처리

고민과 해결과정

연결 과정을 useRTCConnection훅에서 상태를 갖게 할까 하다 RTCConnection의 역할과 책임이 너무 커지는 것 같아서 useRoomConfigData를 통해 상태를 관리하도록 처리했다.

d0422 added 2 commits December 7, 2023 13:29
useRoomConfigData에 connection 관련 상태, 오류 상태 추가
(#211)
roomConfigData Room과 Home에 적용하여 connection 핸들링
(#211)
@d0422 d0422 self-assigned this Dec 7, 2023
@d0422 d0422 requested a review from HBSPS December 7, 2023 04:37
@d0422 d0422 added enhancement 개선 또는 피드백 반영 feature 기능 구현 FrontEnd 프론트엔드 관련 labels Dec 7, 2023
Copy link
Collaborator

@HBSPS HBSPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@d0422 d0422 merged commit afbe41d into boostcampwm2023:dev Dec 7, 2023
6 checks passed
@HBSPS HBSPS mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 개선 또는 피드백 반영 feature 기능 구현 FrontEnd 프론트엔드 관련
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants