Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] feat: 채팅, 문제보기 오류 처리 #234

Merged
merged 5 commits into from
Dec 10, 2023

Conversation

d0422
Copy link
Collaborator

@d0422 d0422 commented Dec 8, 2023

PR 설명

채팅, 문제보기 오류 처리

✅ 완료한 기능 명세

  • 채팅 전송시 form action에 의해 새로고침이 발생하는 오류 해결
  • 문제보기시 url 정규식 필터링
  • 문제보기 오류 발생시 표기

📸 스크린샷

2023-12-08.21-39-51.mp4
2023-12-08.21-41-43.mp4

@d0422 d0422 self-assigned this Dec 8, 2023
@d0422 d0422 force-pushed the FE094/fix/error-chat-quiz branch from d839c35 to 5d1067c Compare December 8, 2023 12:44
@d0422 d0422 requested a review from HBSPS December 8, 2023 12:44
@d0422 d0422 added feature 기능 구현 fix 오류 수정 labels Dec 8, 2023
@d0422 d0422 force-pushed the FE094/fix/error-chat-quiz branch from 5d1067c to 4d40a48 Compare December 8, 2023 12:47
d0422 added 4 commits December 8, 2023 21:53
채팅 보내기 클릭시 form action이 수행되어 새로고침이 되는 문제 해결
api오류 발생시 오류가 발생했다고 표기
url정규식을 통해 정상적인 url만 입력가능하도록 처리
채팅 보내기 클릭시 form action이 수행되어 새로고침이 되는 문제 해결
Copy link
Collaborator

@HBSPS HBSPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

import { isAxiosError } from 'axios';

export default function ErrorView({ error }: { error: Error }) {
console.log(error);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.log가 남아있어요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제거했습니다!

@d0422 d0422 force-pushed the FE094/fix/error-chat-quiz branch from 4d40a48 to ddc163b Compare December 8, 2023 12:54
불필요한 console.log삭제
@d0422 d0422 added FrontEnd 프론트엔드 관련 and removed feature 기능 구현 labels Dec 8, 2023
@HBSPS HBSPS changed the title feat: [FE] 채팅, 문제보기 오류 처리 [FE] feat: 채팅, 문제보기 오류 처리 Dec 8, 2023
@d0422 d0422 merged commit 743ddb8 into boostcampwm2023:dev Dec 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 오류 수정 FrontEnd 프론트엔드 관련
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants