[FE] refactor: 라우팅 로딩 스피너 추가 #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crdt와 modal객체들이 코드스플리팅될 수 있도록 처리
라우팅 로딩스피너 추가
HBSPS
approved these changes
Dec 11, 2023
| <div className="flex flex-col items-center justify-center w-screen h-screen"> | ||
| <div className="basis-2/4 max-w-[400px] max-h-[400px] mobile:hidden animate-pulse"> | ||
| <picture> | ||
| <source srcSet="/main.webp" type="image/webp" /> |
There was a problem hiding this comment.
이미지의 width와 height를 지정해주세요!
이미지 크기 지정
d0422
force-pushed
the
FE094/refactor/loading-spinner
branch
from
47ccfa3 to
9822c9b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 설명
✅ 완료한 기능 명세
📸 스크린샷
2023-12-11.20-15-39.mp4
고민과 해결과정
crdt와 Modal이 home화면에서 로드되는 문제가 있었는데, main.tsx에서 Room.tsx 내부로 옮겨 동적 import될 수 있도록 처리했다.
또한, 동적으로 파일을 가져오는동안 보여줄 로딩 스피너를 추가했다.