[BE] fix: 회원가입 트랜잭션 범위 수정 & 타임아웃 시그널 수정 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SIGINT 시그널로 종료했을 때 코드(130)으로 응답하는 경우도 존재함
HKLeeeee
changed the title
HKLeeeee
changed the title
Gseungmin
reviewed
Dec 14, 2023
| @@ -25,7 +25,8 @@ export class CodesService { | |||
| process.env.NODE_ENV === 'dev' | |||
| ? path.join(__dirname, '..', 'tmp') | |||
| : '/algoitni'; | |||
| private killSignal: NodeJS.Signals = 'SIGINT'; | |||
| private readonly killSignal: NodeJS.Signals = 'SIGINT'; | |||
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 설명
✅ 완료한 기능 명세
📸 스크린샷
고민과 해결과정
코틀린 코드가 타임아웃으로 종료될 때 메시지가 출력되지 않는 오류가 존재했음
-> 다른언어는 종료 시그널
SIGINT로 프로세스가 종료되었는데 코틀린은 종료코드130으로 종료됨SIGINT와 130은 동일한 POSIX 시그널!
따라서 이 프로세스가 어떤 시그널로 종료되었는지 체크하는 부분에 시그널과 코드 두 가지 모두 체크하게 함