Disable -Wnon-virtual-dtor for classes derived from boost::system::error_category #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror_category
Compiler warnings for non-virtual destructors are disabled for
boost::system::error_category but the issue also affects all derived
classes.
error: base class ‘class boost::system::error_category’ has accessible non-virtual destructor [-Werror=non-virtual-dtor]
class netdb_category : public boost::system::error_category
^~~~~~~~~~~~~~
error: ‘class boost::asio::error::detail::netdb_category’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]
error: base class ‘class boost::system::error_category’ has accessible non-virtual destructor [-Werror=non-virtual-dtor]
class addrinfo_category : public boost::system::error_category
^~~~~~~~~~~~~~~~~
error: ‘class boost::asio::error::detail::addrinfo_category’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]
error: base class ‘class boost::system::error_category’ has accessible non-virtual destructor [-Werror=non-virtual-dtor]
class misc_category : public boost::system::error_category
^~~~~~~~~~~~~
error: ‘class boost::asio::error::detail::misc_category’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]
Disable -Wnon-virtual-dtor in the same way that Boost.System does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler warnings for non-virtual destructors are disabled for boost::system::error_category but the issue also affects all derived classes.
Disable -Wnon-virtual-dtor in the same way that Boost.System does.