Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websockets: Count pings from server as activity for idle_timeout #2980

Merged
merged 2 commits into from
Feb 9, 2025
Merged

websockets: Count pings from server as activity for idle_timeout #2980

merged 2 commits into from
Feb 9, 2025

Conversation

ashtum
Copy link
Collaborator

@ashtum ashtum commented Feb 8, 2025

@xim, I merged your commit here because I couldn't reopen #2718.

@xim @ashtum
websockets: Count pings from server as activity for idle_timeout
3b0c2c9 
If the stream is receiving control packets like ping, don't count it as
idle. This means you can enable `timeout_opt.keep_alive_ping` on only
one side to get heartbeat.

Make tests that verify current behaviour.

Update documentation to match changes in PR boostorg#2718.

Addresses issue boostorg#2716
This was linked to issues Feb 8, 2025
Channel timeout related issue #2958
Closed
inactivity_timeout is triggered regardless of having received pings #2716
Closed
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2980.beast.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum ashtum force-pushed the control-frame-as-activity branch from 5555443 to 2e06f24 Compare February 8, 2025 13:53
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2980.beast.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum ashtum force-pushed the control-frame-as-activity branch from 2e06f24 to f18aa0e Compare February 8, 2025 15:29
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2980.beast.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum ashtum force-pushed the control-frame-as-activity branch from f18aa0e to b7239fd Compare February 8, 2025 16:03
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2980.beast.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum ashtum force-pushed the control-frame-as-activity branch from b7239fd to f72ad5d Compare February 8, 2025 17:25
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2980.beast.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum ashtum force-pushed the control-frame-as-activity branch from f72ad5d to 05e18a4 Compare February 8, 2025 19:55
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2980.beast.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum ashtum force-pushed the control-frame-as-activity branch from 05e18a4 to 5fb6a5b Compare February 9, 2025 07:26
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2980.beast.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum ashtum merged commit 95386da into boostorg:develop Feb 9, 2025
74 checks passed
@xim
Copy link
Contributor

xim commented Feb 9, 2025

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Channel timeout related issue inactivity_timeout is triggered regardless of having received pings
3 participants
@ashtum @cppalliance-bot @xim