Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix from_chars handling of non-finite 80 and 128-bit values #115

Merged
merged 17 commits into from
Jan 9, 2024
Merged

Conversation

mborland
Copy link
Member

@mborland mborland commented Jan 8, 2024

Closes: #114

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (319b7c6) 86.22% compared to head (6eef3c2) 86.60%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #115      +/-   ##
===========================================
+ Coverage    86.22%   86.60%   +0.38%     
===========================================
  Files           55       55              
  Lines         7891     7990      +99     
===========================================
+ Hits          6804     6920     +116     
+ Misses        1087     1070      -17     
Files Coverage Δ
...de/boost/charconv/detail/from_chars_float_impl.hpp 65.71% <100.00%> (+7.38%) ⬆️
include/boost/charconv/detail/parser.hpp 74.61% <100.00%> (+3.77%) ⬆️
src/from_chars.cpp 97.77% <100.00%> (+0.63%) ⬆️
test/from_chars_float.cpp 98.58% <100.00%> (+0.07%) ⬆️
test/test_float128.cpp 100.00% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 319b7c6...6eef3c2. Read the comment docs.

@mborland mborland merged commit b909fb8 into develop Jan 9, 2024
53 checks passed
@mborland mborland deleted the 114 branch January 9, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with nan
1 participant