-
Notifications
You must be signed in to change notification settings - Fork 37
Install extra/ directory, and configure .natvis files on Windows #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Let's leave BOOST_INSTALL_INCLUDE_SUBDIR alone and (always, regardless of layout) install into CMAKE_INSTALL_DATADIR/boost-1.90.0. I'll take a look at the rest later. |
It makes more sense to have matching installation for |
No, I don't think it does. The include subdir is maintained for consistency with I don't think that dumping all the So to avoid dumping random things into |
Understood, I can make that change, and remove the configurability from it. |
da55c3f
to
9d467f4
Compare
You have legitimate CI failures if you haven't noticed:
That's probably because when e.g. BOOST_SKIP_INSTALL_RULES is set, EXTRA_INSTALL_DIRECTORY is empty, and your check in boost_install_target precedes the check for BOOST_SKIP_INSTALL_RULES (because boost_install_target does more than just install, and those other things aren't skipped when BOOST_SKIP_INSTALL_RULES is set.) |
… INTERFACE_SOURCES
Thank you Braden for your work on this. I think this is ready to merge and will do so a bit later. |
Great thank you |
Follow-up of #81