feat: add tell() and error() functions to istream + ostream devices #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class file_stream_device already has such functions, and now both istream_device and ostream_device have them, too, making the device classes more consistent. Closes boostorg#724.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #747 +/- ##
========================================
Coverage 82.12% 82.12%
========================================
Files 117 117
Lines 5355 5355
========================================
Hits 4398 4398
Misses 957 957 |
mloskot
added
cat/enhancement
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
tell()anderror()functions toistream_deviceandostream_deviceclasses.The class
file_stream_devicealready has such functions, and now bothistream_deviceandostream_devicehave them, too, making the device classes more consistent.Closes #724.
References
See #724.
Tasklist