Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Boost.Bind usages. #418

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

gogagum
Copy link
Contributor

@gogagum gogagum commented Feb 11, 2025

This PR removes one unnecessary boost::bind usage and replaces some other usages with std::bind, so Boost.Bind can be removed from dependances.

@gogagum
Copy link
Contributor Author

gogagum commented Feb 11, 2025

I will make an attempt of doing some workaronds for Clang.

@gogagum gogagum force-pushed the feature/remove-boost-bind-usages branch from 0492363 to 454863f Compare February 11, 2025 21:28
@gogagum gogagum force-pushed the feature/remove-boost-bind-usages branch from 454863f to 7d7c035 Compare February 11, 2025 21:31
@jeremy-murphy
Copy link
Contributor

Thanks for your effort to improve Boost.Graph, it's really appreciated!
However, I strongly recommend you watch this video about bind and then consider what change you want to make: https://youtu.be/zt7ThwVfap0?si=47AbaJkWFh-VrnBc

@gogagum
Copy link
Contributor Author

gogagum commented Feb 11, 2025

Well, the speaker recommends to avoid std::bind. Do you mean this? I just tried to replace boost::bind with std::bind where possible to make minimal difference. It is not a problem to replace all std::bind usages with lambdas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants