Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing BOOST_FALLTHROUGH in a few cases #1073

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

RoyBellingan
Copy link

After seeing a few test failing for #1071 I added a few more check in my local build, and those 3 popped out

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://1073.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.70%. Comparing base (c02d872) to head (e3531d3).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1073   +/-   ##
========================================
  Coverage    93.70%   93.70%           
========================================
  Files           91       91           
  Lines         9139     9139           
========================================
  Hits          8564     8564           
  Misses         575      575           
Files with missing lines Coverage Δ
include/boost/json/basic_parser_impl.hpp 98.50% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c02d872...e3531d3. Read the comment docs.

@cppalliance-bot
Copy link

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://1073.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

@grisumbras grisumbras merged commit e3531d3 into boostorg:develop Feb 24, 2025
3 checks passed
@grisumbras
Copy link
Member

Thank you for your contribution.

@RoyBellingan
Copy link
Author

Each Journey begin with one step!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants