-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for speed and consistency #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #252 +/- ##
========================================
Coverage 95.87% 95.87%
========================================
Files 117 119 +2
Lines 10406 10410 +4
========================================
+ Hits 9977 9981 +4
Misses 429 429
Continue to review full report in Codecov by Sentry.
|
Flamefire
force-pushed
the
refactor
branch
5 times, most recently
from
January 6, 2025 08:42
0de23c0
to
9f07faa
Compare
Useful if next check(s) depend on previous ones.
This is compatible to `std::string_view` and also to `boost::string_view` so hence the better option.
The issue was caused by using an incompatible libstdc++. For Clang 13 & 14 libstdc++ 11 works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try_to_int
to new header moving it out of a header containing the largebase_num_format
.try_to_int
try_to_int
to be used with other integer types, e.g. theunsigned
as used with in one other placevector
to have it non-const. The latter is only required for FreeBSD and apple, not for all Linux systems.TEST
macro to allow depending on the return value for further tests