Skip to content

Add manual promotion to arcsine, beta, and Bernoulli distributions #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

mborland
Copy link
Member

This is an extension to #1294 since it looks like most of the distributions have functions where manual promotion needs to be applied to follow what the policy says. I tried to reduce the ugliness as much as possible, but the result is that the code is generally less readable than it is without this PR. Thoughts @jzmaddock and @WarrenWeckesser. If there's no real opposition I can continue plugging along with this.

Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.47%. Comparing base (483f36c) to head (2852b4b).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1299      +/-   ##
===========================================
- Coverage    95.07%   94.47%   -0.60%     
===========================================
  Files          796      686     -110     
  Lines        67020    49438   -17582     
===========================================
- Hits         63717    46705   -17012     
+ Misses        3303     2733     -570     
Files with missing lines Coverage Δ
include/boost/math/distributions/beta.hpp 77.27% <ø> (-8.16%) ⬇️
include/boost/math/policies/policy.hpp 95.83% <ø> (ø)

... and 138 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 483f36c...2852b4b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant