-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python-related redefinitions for builds using mingw-w64 #141
base: develop
Are you sure you want to change the base?
Conversation
By "broke MSVC builds", are you referring to the Appveyor build failure ? That's an unrelated issue with the SCons build logic. Boost.Build is not involved in the CI builds. If not, can you show an error log ? (I'm only a casual Windows user, so I may not be able to help.) |
Travis failures forced me to test this patch for MSVC builds. Which I missed to do before publishing this PR.
(see logs in attachment). |
@@ -36,6 +36,8 @@ py3-version = [ py-version 3 ] ; | |||
|
|||
project boost/python | |||
: source-location ../src | |||
: requirements <toolset>gcc <target-os>windows:<cxxflags>-D_hypot=hypot | |||
: requirements <toolset>gcc <target-os>windows <link>shared:<cxxflags>-DMS_WIN64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is doing what you expect. As far as I understand Boost.Build syntax, the last line above defines as requireents:
- toolset=gcc
- target-os=windows
- cxxflags=-DMS_WIN64, whenever link=shared
It looks like what you intend to do is to define -DMS_WIN64 whenever all three features (toolset, target-os, and link) have the given values, yes ?
Please ask on the boost or boost.build mailing list what the right syntax for this is.
(I'm also not sure how this would fix the `"gcc is not a known value..." error. That's another thing to ask on boost.build ML).
Sorry I can't help more with this. Boost.Build is complicated and badly documented, which is one reason why I'm trying to move away from it...
I was trying to add rules to Boost.Python build system:
Or we can invite Boost.Build Developers to join this discussion. |
Fixes #140.
Tested for builds using mingw-w64 with
<Debug|Release><Shared|Static>
configurations.UPDATE: But it broke MSVC builds. Any suggestions?