Close the file handle used in exec_file() (for #52) #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For python >= 3, a plain `FILE*` is used, whereas for python2, an object handle takes care of the file object lifetime. This commit manually closes the file handle after the `PyRun_File()` call.
|
I still have this problem, can this be merged soon? |
|
Actually for some reason this causes an access violation:
So.. maybe doesn't work quite right :) |
|
Can you reproduce easily ? Do you have a backtrace ? |
|
@hotgloupi I undid the patch and don't have a backtrace. Under python 3.4 however it seems the file descriptor was cleaned up already, resulting in multiple fdclose calls on the descriptor. I didn't have too much time to look into it. |
stefanseefeld
force-pushed
the
develop
branch
2 times, most recently
from
8ccdcff
to
3ace4a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For python >= 3, a plain
FILE*is used, whereas for python2, an object handle takes care of the file object lifetime.This commit manually closes the file handle after the
PyRun_File()call.