Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arbitrary precision rationals with negative denominator #41

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

psavouli
Copy link

Fix for #27.

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #41 into develop will decrease coverage by 3.19%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop      #41     +/-   ##
==========================================
- Coverage    70.11%   66.91%   -3.2%     
==========================================
  Files            1        1             
  Lines          271      272      +1     
  Branches        90       94      +4     
==========================================
- Hits           190      182      -8     
  Misses           3        3             
- Partials        78       87      +9
Impacted Files Coverage Δ
include/boost/rational.hpp 66.91% <0%> (-3.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47c1b26...ae740e4. Read the comment docs.

@psavouli psavouli requested review from jeking3 and ahmedcharles and removed request for ahmedcharles February 13, 2020 22:10
@psavouli
Copy link
Author

Could I have some help here please? I do not quite know how the coverage report is setup to reproduce it. Equally the master and develop branches show 70% and 67% coverage respectively, even though both branches are the same. So I can't quite tell if there is actually something wrong with my change or something else is going on. Thanks.

@bjodah
Copy link

bjodah commented May 18, 2020

Just wanted to report that this patch works wrt. this issue in downstream SymEngine:
symengine/symengine#1639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants