Enables -Wall and -Werror in CIs #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've split this from #250 to make it more self-contained. -Werror here is useful if using Boost lightweight test (included in Boost.Core), which I think we should use here instead of Boost.Test (it's much more lightweight). In lightweight test, tests are just functions that get called from main(). Building with -Werror makes uncalled tests an error. In any case, it's useful that header-only libraries ship with as few warnings as possible, since they get propagated to user code. |
|
Merging as requested by Marcelo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some warnings due to unused variables, signed to unsigned comparisons, and superfluous moves