Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X3: Fix inconsistent error position for p vs p >> eps or repeat(1)[p] in error_handler #719

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Commits on Feb 17, 2022

  1. X3: Do not rely on iterator rollback on fail

    Preparation to relax iterator rollback policy, which is also currently violated by not rolling back skipper almost everywhere, so this should fix postskip disabling.
    Kojoley committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    a56d7ef View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2022

  1. X3: Remove unneeded iterator rollback

    Under the current iterator rollback policy rollbacks could be omitted in compound parser which don't advance iterator themselves because the called subparser is responsible for rollback on failure. In reality these rollbacks are undoing skipper work what renders as inconsistency in error handling position (`p` vs `p >> eps` or `repeat(1)[p]`).
    Kojoley committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    161c601 View commit details
    Browse the repository at this point in the history