Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for :boot-jvm-options #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jeroenvandijk
Copy link

This patch fixes the use of the :jvm-options property (via one of the config options) as documented in the WIKI

Testing

Add BOOT_JVM_OPTIONS=-XX:-OmitStackTraceInFastThrow to your boot.properties file

Now start a boot repl and run this command:

(let [x (fn [] (/ nil 1)) cnt0 20000] (loop [cnt 0] (when-not (= cnt cnt0) (recur (try (x) (catch Exception e (print ".") (flush) (if (seq (.getStackTrace e)) (inc cnt) (do (println "No stacktrace at" cnt) cnt0))))))))

It will say "No stacktrace at ***", where the number is probably smaller than 10000.

Now compile boot again from this branch:

 make bin/boot.sh backup-boot-bin install-boot-bin

And the above steps will not give "No stacktrace at ***"

The old boot script can be reverted via

make restore-boot-bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant