-
Notifications
You must be signed in to change notification settings - Fork 11
tests: Add a failing test case for OpenImageOptional with oci-archive #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Prep for fixing it. Signed-off-by: Colin Walters <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new failing test case to pinpoint and expose an existing bug related to how the OpenImageOptional
function handles non-existent oci-archive
images. This is a preparatory step to ensure the bug is properly captured before a fix is implemented.
Highlights
- New Dependency: Added the
tempfile
crate as a new dependency inCargo.toml
to facilitate the creation of temporary directories, primarily for testing purposes. - Test Utility Function: Introduced a new helper function
check_skopeo
within the test module ofsrc/imageproxy.rs
. This function usesOnceLock
to efficiently check for the presence of theskopeo
command-line tool, allowing tests to conditionally run based on its availability. - Failing Test Case for
OpenImageOptional
: Added a new asynchronous testtest_open_optional
insrc/imageproxy.rs
. This test is specifically designed to expose a bug (linked tocoreos/rpm-ostree/issues/5442
) whereImageProxy::open_image_optional
is expected to returnNone
when given a path to a non-existentoci-archive
image. The test is currently marked with#[ignore]
because it's intended to fail, highlighting the current incorrect behavior, and will pass once the underlying bug is fixed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new test case for OpenImageOptional
with oci-archive
. The review focuses on improving the robustness of the new test and dependency management.
Prep for fixing it.