Skip to content

tests: Add a failing test case for OpenImageOptional with oci-archive #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cgwalters
Copy link
Collaborator

Prep for fixing it.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new failing test case to pinpoint and expose an existing bug related to how the OpenImageOptional function handles non-existent oci-archive images. This is a preparatory step to ensure the bug is properly captured before a fix is implemented.

Highlights

  • New Dependency: Added the tempfile crate as a new dependency in Cargo.toml to facilitate the creation of temporary directories, primarily for testing purposes.
  • Test Utility Function: Introduced a new helper function check_skopeo within the test module of src/imageproxy.rs. This function uses OnceLock to efficiently check for the presence of the skopeo command-line tool, allowing tests to conditionally run based on its availability.
  • Failing Test Case for OpenImageOptional: Added a new asynchronous test test_open_optional in src/imageproxy.rs. This test is specifically designed to expose a bug (linked to coreos/rpm-ostree/issues/5442) where ImageProxy::open_image_optional is expected to return None when given a path to a non-existent oci-archive image. The test is currently marked with #[ignore] because it's intended to fail, highlighting the current incorrect behavior, and will pass once the underlying bug is fixed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new test case for OpenImageOptional with oci-archive. The review focuses on improving the robustness of the new test and dependency management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants