rescue instead if actiontext could not be found #706
Conversation
| require "#{Gem::Specification.find_by_name('actiontext').gem_dir}/app/helpers/action_text/tag_helper" | ||
| rescue Gem::MissingSpecError |
There was a problem hiding this comment.
I can see why this is a better solution. I wonder if it would be worthwhile writing an error message in the rescue case. It might be better than silently swallowing the error. (Admittedly this could also be said of the current code.) What do you think?
There was a problem hiding this comment.
That would mean that any application that is loaded without actiontext would always get an error message. It might be more useful to put error handling when the user attempts to use the action text tag helper.
There was a problem hiding this comment.
Of course. Good point. And when they try to use the action text helper, they'll get a obvious (by Rails standards, at least) error message. Thanks for walking me through the thinking!
|
You can ignore the failures against edge Rails, but please fix up the lint issue by ignoring the RuboCop warning. |
|
@lcreid done! |
No description provided.