1.2.0 release #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-ryan-ashcraft
commented
Apr 19, 2024
| @@ -54,7 +54,7 @@ jobs: | |||
| git config --local user.name "Github Actions" | |||
| git checkout -b ${{ inputs.releaseVersion }}-release | |||
| mvn -B release:clean release:prepare release:perform -Possrh-release -DreleaseVersion=${{ inputs.releaseVersion }} -DdevelopmentVersion=${{ inputs.developmentVersion }} -Darguments="-Dhabushu.usePyenv=false" | |||
There was a problem hiding this comment.
I (Informational): updated based on some post-release processing that didn't work in the GitHub Action
There was a problem hiding this comment.
Just curious what was the issue here? Do we need to update the other technology brewery release scripts as well?
There was a problem hiding this comment.
versions:set doesn't cover the licenses-example-projects pom file. But release:update-versions does.
I think eliminating the shell script in favor of the release plugin would be worthwhile at some point on the technology brewery projects, but not a major priority IMO unless something is broken.
colinpalmer-pro
approved these changes
Apr 19, 2024
jacksondelametter
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.