Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove editorconfig #310

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Remove editorconfig #310

merged 1 commit into from
Apr 16, 2024

Conversation

eirnym
Copy link
Contributor

@eirnym eirnym commented Apr 16, 2024

No description provided.

@eirnym
Copy link
Contributor Author

eirnym commented Apr 16, 2024

@boozook could you please merge this PR?

@boozook
Copy link
Owner

boozook commented Apr 16, 2024

@eirnym, thanks for awesome contribution 👍

According to #235, where you've told:

Otherwise contributing could be painful
...
EditorConfig would be useful though to make editors format in more or less the same way (at least what's about the tabs and spaces)

So my question is -
Would you plz describe your reasons to delete it now?

@eirnym
Copy link
Contributor Author

eirnym commented Apr 16, 2024

As you mentioned, it's not possible to include all formatting into this file and rustfmt won't support this file any time soon.

Additionally, even this file supports very basic rules common to every editor for Rust code, it doesn't include any rules for other file types and could potentially lead to inconsistency as root=true is present. If it wasn't present, more inconsistency could be introduced.

Thus, it's better to have either all used types included, or file is not included at all.

@boozook boozook enabled auto-merge April 16, 2024 14:23
Copy link
Owner

@boozook boozook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explanation. LGTM 👍

@boozook boozook merged commit 50d8daa into boozook:main Apr 16, 2024
26 checks passed
@boozook boozook added the enhancement New feature or request label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants