-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for updating state in serial message callback #375
Merged
boozook
merged 8 commits into
boozook:main
from
paulyoung:update-state-in-serial-message-callback
Jun 15, 2024
Merged
Add example for updating state in serial message callback #375
boozook
merged 8 commits into
boozook:main
from
paulyoung:update-state-in-serial-message-callback
Jun 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
Improvements or additions to documentation
api
About Playdate API, bindings and all over that.
labels
Jun 8, 2024
paulyoung
changed the title
[WIP] Update state in serial message callback
Add example for updating state in serial message callback
Jun 8, 2024
I think I have a version of this that seems reasonable. I’ll push that and then perhaps we can discuss alternatives. |
I suspect that trying to update other parts of the state within I’ll add that and see what comes up. |
paulyoung
commented
Jun 9, 2024
paulyoung
commented
Jun 9, 2024
boozook
reviewed
Jun 10, 2024
boozook
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to share this example since I think it's a fairly reasonable thing to want to do.
This currently fails with:
The workarounds that I came up with so far weren't very satisfying and basically bypassed
State
altogether.