Fix the problem of capslock on macOS #381
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am a macOS user.
I am using this module to do some interesting things, I think this module is very useful.
But, I found a problem.
If you check the option in the red box in macOS keyboard settings, the following error will appear when the capslock is pressed.
After debugging, I found the reason.
This line of code returned an invalid value 0xFF, I don't know why this happened, but it did happen.
scan_code = Quartz.CGEventGetIntegerValueField(event, Quartz.kCGKeyboardEventKeycode)
https://github.com/boppreh/keyboard/blob/master/keyboard/_darwinkeyboard.py#L375
This API is provided by Apple, but I can't find document about the return value 0xFF, maybe it stands for invalid.
I tried to deal with this invalid value, and now it works well on my macbook.
By the way, I am using macOS 10.15.5.
If you think this is valuable, please merge it.
Thx.