Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FixedSizeVector and FixedSizeMatrix are named too consistently #159

Open
dabrahams opened this issue Aug 8, 2020 · 1 comment
Open

FixedSizeVector and FixedSizeMatrix are named too consistently #159

dabrahams opened this issue Aug 8, 2020 · 1 comment

Comments

@dabrahams
Copy link
Collaborator

one being a protocol and the other a generic type will lead to confusion.
@marcrasi
Copy link
Collaborator

I want to remove the "FixedSize" part of the name because there's no reason why it can't work for dynamically sized collections and vectors. (Though some of the methods rely on the fixed sizedness now so they will need to be changed first.)

Maybe s/FixedSizeMatrix/MatrixView/, since it views a collection of vectors as a matrix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dabrahams @marcrasi