Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adapt to new jax API #338

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: adapt to new jax API #338

wants to merge 1 commit into from

Conversation

GaetanLepage
Copy link

Tests are currently broken when ran with the latest version of JAX installed.
This patch ensures the code compatibility with the current jax API.

@borisdayma
Copy link
Owner

borisdayma commented Nov 15, 2023 •
edited
Loading

Thanks, that's all you needed to change?
I'm scared the training code will most likely be broken with latest version as well.

I pinned the versions to use here:

dalle-mini/setup.cfg

Line 32 in f0be4de

jax==0.3.25

@GaetanLepage
Copy link
Author

Thanks, that's all you needed to change?

Well at least, it is enough for all of the tests to pass.
For the context, I was updating dalle-mini to the latest version on nixpkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GaetanLepage @borisdayma