Feature: use request #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JuraJuki
commented
Aug 25, 2020
JuraJuki
commented
- add use request hook
- addresses this issue Add useRequest #25
…o feat/attributes-obj-removal
Feature: extract tsdx-readme
…o feat/attributes-obj-removal
…esMapper, fix tests
Feature: attributes {} obj removal
Fix: change package-lock.json to yarn.lock
…ntGeneratedEntity
Feature: fix attributes {} if __clientGeneratedEntity only attribute
renatoruk
reviewed
Sep 15, 2020
| } from "axios"; | ||
| import { useState } from "react"; | ||
|
|
||
| export const useRequest = ( |
There was a problem hiding this comment.
The hook seems nice, I think it'll really help in some scenarios such as upload for example.
I have an idea on how to get around the issue of having to pass axiosInstance in every call.
We could use useContext for this.
But, for this we'll need to have aardvark instantiated in the root of the application and then passed to a AardvarkProvider (which is currently in test-utils, but I think that the provider should be exported and required for implementation)
Fix: page params camelCase syntax
Co-authored-by: Renato Ruk <[email protected]>
Fix: json api reducer - delete request
Fix: nested attributes {}
# Conflicts: # src/test-utils/configureStore.ts # src/tests/deleteHookTests.test.tsx # src/tests/patchHookTests.test.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.