Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More links to talk recordings #51

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Conversation

th0n0s
Copy link
Contributor

@th0n0s th0n0s commented Jul 28, 2023

No description provided.

Copy link
Collaborator

@swvanbuuren swvanbuuren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you creating a new page with recordings?
Why not add the recordings links to each individual keynote/talks page?
The recordings page is also not listed in the menu.

My advice is:
Change the presentation macro (https://github.com/boschglobal/embedded-linux/blob/master/include/presentation.md?plain=1):

  • Duplicate the slides part. Rename the section to Recording, keyword to recordingand make other appropriate changes.
  • Then you can add a link to keynotes.yaml or talks.yaml to display a link on each individual keynote or talk page.

@th0n0s
Copy link
Contributor Author

th0n0s commented Jul 28, 2023

Thanks for your advice. We discussed what would be the easiest way to provide the links. Because we are not very familar with your macro structure, we decided to add a new recording page and add a link on top of the "speaker" page. Initially I wanted to add a new menue item, but wasn't sure and didn't want to destroy something.
Because there were many requests we published the page with keynote recordings yesterday and shared it with the LF EU. So if you don't mind I'd like to proceed with the new recording page as a interim solution and once you are back you could do it in the right way

@th0n0s
Copy link
Contributor Author

th0n0s commented Jul 28, 2023

Also, Philipp and I are on vacation next week. I don't know whether Dirk/Fofi can implement what you requested

@th0n0s
Copy link
Contributor Author

th0n0s commented Jul 28, 2023

let me give it a trial this aftenoon. Problem is that I can't verify if my changes work.

@swvanbuuren
Copy link
Collaborator

@th0n0s ok, you can merge if you'd like.

Fwiw, you could ask someone from the MVP team to make the changes I am suggesting.

@swvanbuuren swvanbuuren merged commit feeae05 into boschglobal:master Jul 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants