Add get getSellersCollectionsPaginated method #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -450,7 +450,8 @@ interface IBosonAccountHandler is IBosonAccountEvents, BosonErrors { | |||
| ) external view returns (bool exists, BosonTypes.Seller memory seller, BosonTypes.AuthToken memory authToken); | |||
|
|
|||
| /** | |||
| * @notice Gets the details about a seller's collections. | |||
| * @notice Gets the details about all seller's collections. | |||
| * In case seller has too many collections and this runs out of gas, pleas use getSellersCollectionsPaginated. | |||
There was a problem hiding this comment.
Suggested change
| * In case seller has too many collections and this runs out of gas, pleas use getSellersCollectionsPaginated. | |
| * In case seller has too many collections and this runs out of gas, please use getSellersCollectionsPaginated. |
There was a problem hiding this comment.
same typo in other places
albertfolch-redeemeum
previously approved these changes
Nov 30, 2023
albertfolch-redeemeum
approved these changes
Nov 30, 2023
levalleux-ludo
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #709
Implementation is slightly different than proposed in the issue. It matches the pattern in the existing
getTokenListPaginated.This allows to retrieval of multiple collections with a single call, but with more granular control.
Changes:
getSellersCollectionsPaginatedtoSellerHandlerFacet