feat: add asBlob parameter to baseIpfsStorage to retrieve ipfs item a… #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+109
to
+110
| if (!asJson && asBlob) { | ||
| return response.blob(); |
There was a problem hiding this comment.
main change are these 2 lines
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #787 +/- ##
==========================================
+ Coverage 90.11% 90.13% +0.02%
==========================================
Files 162 162
Lines 6009 6044 +35
Branches 915 921 +6
==========================================
+ Hits 5415 5448 +33
- Misses 594 596 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
levalleux-ludo
approved these changes
Aug 5, 2024
albertfolch-redeemeum
deleted the
feat-add-asBlob-parameter-get-ipfs-item
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s a blob