Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: a few changes required to run the opensea flow on Fermion prot… #789

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

levalleux-ludo
Copy link
Member

…ocol

Description

  • add ability to set optional Transaction Request arguments (like gasPrice) on ERC20 and ERC721 handlers
  • add withWrapper boolean argument to opensea buildAdvancedOrder() method

How to test

N/A

@levalleux-ludo levalleux-ludo marked this pull request as ready for review August 28, 2024 10:05
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.09%. Comparing base (82d3516) to head (7166e75).
Report is 2 commits behind head on main.

Files Patch % Lines
packages/core-sdk/src/marketplaces/opensea.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #789      +/-   ##
==========================================
- Coverage   90.13%   90.09%   -0.05%     
==========================================
  Files         162      162              
  Lines        6044     6047       +3     
  Branches      921      924       +3     
==========================================
  Hits         5448     5448              
- Misses        596      599       +3     
Flag Coverage Δ
common 92.11% <ø> (ø)
core-sdk 57.99% <20.00%> (-0.04%) ⬇️
e2e 87.28% <20.00%> (-0.05%) ⬇️
eth-connect-sdk 97.33% <ø> (ø)
ethers-sdk 70.03% <ø> (ø)
ipfs-storage 89.41% <ø> (ø)
metadata 94.70% <ø> (ø)
unittests 61.63% <20.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@levalleux-ludo levalleux-ludo merged commit 14017f8 into main Aug 28, 2024
7 of 11 checks passed
@levalleux-ludo levalleux-ludo deleted the opensea-fermion-flow branch August 28, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant