Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base button props #828

Merged
merged 2 commits into from
Nov 7, 2024
Merged

fix: base button props #828

merged 2 commits into from
Nov 7, 2024

Conversation

max-koz
Copy link
Collaborator

@max-koz max-koz commented Nov 7, 2024

Description

{{what was done}}

How to test

{{how can it be tested}}

@max-koz max-koz self-assigned this Nov 7, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.50%. Comparing base (7a4b4ba) to head (0ed10ab).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   90.26%   87.50%   -2.77%     
==========================================
  Files         163      156       -7     
  Lines        6061     6050      -11     
  Branches      927      927              
==========================================
- Hits         5471     5294     -177     
- Misses        590      756     +166     
Flag Coverage Δ
common ?
core-sdk ?
e2e 87.19% <ø> (ø)
eth-connect-sdk 94.87% <ø> (ø)
ethers-sdk 69.62% <ø> (ø)
ipfs-storage 89.41% <ø> (ø)
metadata 94.70% <ø> (ø)
unittests 82.75% <ø> (+19.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@max-koz max-koz merged commit ea7969d into main Nov 7, 2024
7 of 11 checks passed
@max-koz max-koz deleted the base-button-props-fix branch November 7, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants