Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to protocol v2.3.0 #55

Closed
wants to merge 2 commits into from
Closed

Conversation

levalleux-ludo
Copy link
Member

@levalleux-ludo levalleux-ludo commented Sep 1, 2023

WIP
STILL TO BE DONE

  • fix transaction failure when redeeming (with meta-tx via Biconomy - no problem when direct transactions)
  • check other usecases

@levalleux-ludo levalleux-ludo marked this pull request as draft September 1, 2023 16:00

export function getDefaultConfigId(envName: EnvironmentType): ConfigId {
if (getEnvConfigs(envName).length === 0) {
throw new Error(`No config found for envNAme '${envName}'`);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new Error(`No config found for envNAme '${envName}'`);
throw new Error(`No config found for envName '${envName}'`);

@levalleux-ludo
Copy link
Member Author

upgrade done with other PRs

@levalleux-ludo levalleux-ludo deleted the upgrade_v2.3.0 branch November 21, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants