lib/discordgo: properly add ThreadMetadata #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `ThreadMetadata` properly to `discordgo.Channel`, that is,
remove the flattened duplicate entries from said struct and instead keep
just `discordgo.ThreadMetadata`.
As a consequence, this cascades to dstate as well as common/templates,
which were modified to reflect that change; as an added bonus, this now
properly represents the channel structure as defined by Discord, rather
than a custom flattened one.
BREAKING CHANGE:
`.Channel.{Locked,Archived}` will be moved to `.Channel.ThreadMetadata.*`.
Migrate by adding that additional layer to your accessing of these
fields. Reports indicate this hasn't worked properly anyway, therefore
this breakage should be acceptable.
Signed-off-by: Luca Zeuch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
ThreadMetadataproperly todiscordgo.Channel, that is,remove the flattened duplicate entries from said struct and instead keep
just
discordgo.ThreadMetadata.As a consequence, this cascades to dstate as well as common/templates,
which were modified to reflect that change; as an added bonus, this now
properly represents the channel structure as defined by Discord, rather
than a custom flattened one.
BREAKING CHANGE:
.Channel.{Locked,Archived}will be moved to.Channel.ThreadMetadata.*.Migrate by adding that additional layer to your accessing of these
fields. Reports indicate this hasn't worked properly anyway, therefore
this breakage should be acceptable.
Signed-off-by: Luca Zeuch [email protected]